Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: footer accessibility problems #793

Merged
merged 10 commits into from
Feb 6, 2024
Merged

fix: footer accessibility problems #793

merged 10 commits into from
Feb 6, 2024

Conversation

virus-rpi
Copy link
Collaborator

Changes:

  • On mobile or narrow screens the text size of the language switcher and the legal links are increased from 14px to 18px
  • Add a aria-label to the language switcher ("Sprachauswahl" / "Language selection")
  • State that the social links will open a new tab in the aria-label (https://www.a11yproject.com/checklist/#identify-links-that-open-in-a-new-tab-or-window)
  • Converted the elements in the legal links list to
  • elements (Improves the Lighthouse accessibility score => better SEO)

@virus-rpi virus-rpi requested a review from a team as a code owner January 15, 2024 13:20
Copy link

netlify bot commented Jan 15, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit b48056c
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/65c104390897600009fd2c5c
😎 Deploy Preview https://deploy-preview-793--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 76 (🔴 down 18 from production)
Accessibility: 100 (🟢 up 3 from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine so far, just some small remarks.

src/templates/blog-post.tsx Outdated Show resolved Hide resolved
src/components/layout/navigation/navigation.tsx Outdated Show resolved Hide resolved
@virus-rpi virus-rpi requested a review from maxmarkus February 5, 2024 15:52
Copy link
Contributor

@maxmarkus maxmarkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the changes.

@virus-rpi virus-rpi merged commit 682ee7b into main Feb 6, 2024
6 checks passed
@virus-rpi virus-rpi deleted the chore/a11y/footer-fixes branch February 6, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants