-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: contact page accessibility problems #792
Conversation
✅ Deploy Preview for satellytes ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the good catches! Especially the honeypot thing is embarasing 😬 I've found some issues to fix, thanks!
# Conflicts: # src/templates/blog-post.tsx
…field because screen reader says what is mandatory
Idea: How about setting the whole map as aria-hidden? For visually impaired people it seems to bring no benefits, it has 5-6 links that can be tabbed and the readout is weird (screenshot below). Since we have the google maps link below, that might be enough. Edit: After writing this, I realized that leafletjs is accessible. But the idea can still be valid. |
# Conflicts: # src/components/layout/theme.tsx
…ill in the tab order)
I found a way to make the map aria-hidden but it is still tab focusable and i could not figure out how to remove it from the tab order ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Despite the fact that the general description "see no evil monkey emoji, because it's embarrassing" feels a bit weird I am approving it. We might think about rewording anyway.
Changes: