-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: blog page accessibility problems #791
Conversation
feat: disable buttons if visually disabled feat: make button tab focusable if enabled
✅ Deploy Preview for satellytes ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch! I have an important change to make and then we can merge it
LGTM. It works as expected. The failing test is the same prettier It is the same formatting change that occurred in the other PR, so I wonder if this is some formatting by your IDE, since prettier doesn't create that change. |
Changes:
Before:
<: Next Page
>: Previous Page
After:
<: Previous Page
>: Next Page
Before:
"List 1 item"
"link, item, image, rss.xml, list 2 item"
After:
"link, image, Subscribe to blog"