Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: blog page accessibility problems #791

Merged
merged 9 commits into from
Jan 30, 2024
Merged

Conversation

virus-rpi
Copy link
Collaborator

Changes:

  • The < and > buttons now have the correct aria-lables.
    Before:
    <: Next Page
    >: Previous Page
    After:
    <: Previous Page
    >: Next Page
  • When on the first/last page you can't press the next / previous page button anymore
  • The button are now tab focusable if enabled
  • Improved screen reader text of RSS button
    Before:
    "List 1 item"
    "link, item, image, rss.xml, list 2 item"
    After:
    "link, image, Subscribe to blog"
  • Made the color contrast for the timestamp WCAG AA compliant

noa.santo added 3 commits January 9, 2024 16:51
@virus-rpi virus-rpi requested a review from a team as a code owner January 9, 2024 16:15
Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit ecf3d1e
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/65b90362e32c1f000887a255
😎 Deploy Preview https://deploy-preview-791--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 87 (🟢 up 1 from production)
Accessibility: 97 (🟢 up 3 from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@virus-rpi virus-rpi changed the title Blog accessibility fixes fix: blog accessibility problems Jan 9, 2024
@virus-rpi virus-rpi changed the title fix: blog accessibility problems fix: blog page accessibility problems Jan 9, 2024
Copy link
Member

@georgiee georgiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! I have an important change to make and then we can merge it

src/components/layout/theme.tsx Show resolved Hide resolved
src/components/ui/pagination/pagination.tsx Show resolved Hide resolved
src/components/ui/pagination/pagination.tsx Show resolved Hide resolved
@virus-rpi virus-rpi requested a review from georgiee January 23, 2024 16:50
@maxmarkus maxmarkus self-requested a review January 29, 2024 13:17
@maxmarkus
Copy link
Contributor

maxmarkus commented Jan 29, 2024

LGTM. It works as expected. The failing test is the same prettier seo.tsx issue as described in the previous PR. Once this is fixed, PR should be green and ready to merge.

It is the same formatting change that occurred in the other PR, so I wonder if this is some formatting by your IDE, since prettier doesn't create that change.

@maxmarkus maxmarkus dismissed georgiee’s stale review January 30, 2024 14:10

changes were done

@virus-rpi virus-rpi merged commit ac22ced into main Jan 30, 2024
6 checks passed
@virus-rpi virus-rpi deleted the chore/a11y/blog-fixes branch January 30, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants