Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: replace react-helmet with gatsby head api #785

Merged
merged 9 commits into from
Dec 6, 2023
Merged

feat: replace react-helmet with gatsby head api #785

merged 9 commits into from
Dec 6, 2023

Conversation

WiebkeFr
Copy link
Contributor

@WiebkeFr WiebkeFr commented Nov 29, 2023 •
edited
Loading

This PR replaces the gatsby-plugin-react-helmet(will be deprecated) with the Gatsby Head API

Why?

  • gatsby allows build-in Head to add element to document head of the pages
  • more performant, easier to use than gatsby-plugin-react-helmet + react-helmet

How to test:

  • open preview link and check of the pages
  • open preview link and check SEO data of the pages

@netlify Netlify
Copy link

netlify bot commented Nov 29, 2023 •
edited
Loading

✅ Deploy Preview for satellytes ready!

Name Link
🔨 Latest commit 3c9f246
🔍 Latest deploy log https://app.netlify.com/sites/satellytes/deploys/65704d022462610008595208
😎 Deploy Preview https://deploy-preview-785--satellytes.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 89 (🟢 up 1 from production)
Accessibility: 94 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@WiebkeFr WiebkeFr marked this pull request as ready for review December 6, 2023 10:35
@WiebkeFr WiebkeFr requested a review from a team as a code owner December 6, 2023 10:35
milljoniaer
milljoniaer approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@milljoniaer milljoniaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! LGTM 🚀

@WiebkeFr WiebkeFr merged commit e42f76a into main Dec 6, 2023
6 checks passed
@WiebkeFr WiebkeFr deleted the feat/gatsby-head-api branch December 6, 2023 15:20
@WiebkeFr WiebkeFr mentioned this pull request Dec 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milljoniaer milljoniaer milljoniaer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WiebkeFr @milljoniaer