fix: adapt base url to netlify #784
Conversation
✅ Deploy Preview for satellytes ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Hey thanks for finding and fixing this.
Can you share your level of confidence if this will work on production later too?
Regarding the preview url I was able to verify everything works with a link tester tool like https://socialsharepreview.com
| export const BRANCH_PREVIEW_URL = buildGatsbyCloudPreviewUrl({ | ||
| prefix: GATSBY_SITE_PREFIX, | ||
| export const NETLIFY_DOMAIN_NAME = process.env.GATSBY_NETLIFY_DOMAIN_NAME || ''; | ||
| export const BRANCH_PREVIEW_URL = buildNetlifyPreviewUrl({ |
There was a problem hiding this comment.
the preview being null is mostly the case for non-preview environments. It will then use GATBSY_BASE_URL (following line). Is this something we create or given by netlify? Asking to make sure this will work when we merge it, because right now I can only verify the preview part of this PR and I fear it's not working later on production. Do you have confidence that this will work then? Thanks!
There was a problem hiding this comment.
The GATSBY_BASE_URL (and also the GATSBY_PREFIX which I changed to GATSBY_NETLIFY_DOMAIN_NAME) was part of our environment configuration on gatsby cloud and got lost on the migration to netlify. I readded it in the netlify settings. Hence, it currently works again on production. This PR only fixes the feature branch BASE_URL. for the main branch the BRANCH_PREVIEW_URL will still be "null" and the GATSBY_BASE_URL will be used. And since that works currently on production, I am confident, that it will still work once this PR is merged. But I will monitor it.
What was done?
The Base URL was previously adapted to gatsby cloud pr deployments. This PR changes that to the netlify pattern.
How to verify?
Verify that on the preview of this PR, the base URL of the meta images is the same as the preview URL:
