publish 0.3.0 #99
publish 0.3.0 #99
Conversation
satsearch/search.py
Outdated
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| API_URL = os.getenv('STAC_API_URL', 'https://1tqdbvsut9.execute-api.us-west-2.amazonaws.com/v0').rstrip('/') + '/' | |||
| API_URL = os.getenv('STAC_API_URL', 'https://earth-search.aws.element84.com/v0').rstrip('/') + '/' | |||
There was a problem hiding this comment.
👋 @matthewhanson what do you think about removing any hardcoded URL? you could still use STAC_API_URL environ but I think it will be better if stac-search wasn't tied to any URL.
We (Devseed) will love to fix the API we are hosting but it means first we have to wait for the specification do be complete.
|
@vincentsarago Sure, I think it's fine to not have any default URL. Let's see, I'll
|
Here what I had in mind:
|
|
@matthewhanson - could this be merged? Trying to work on intake/intake-stac#49 with sat-stac 0.4.0, but the latest release of sat-search pins |
README.md
Outdated
| api.us-east-1.amazonaws.com/prod) | ||
| --headers HEADERS | ||
| JSON Request Headers (file or string) (default: None) | ||
| --url URL URL of the API (default: https://earth-search.aws.element84.com/v0/) |
There was a problem hiding this comment.
there is no more default here!
tutorial-1.ipynb
Outdated
| @@ -12,7 +12,7 @@ | |||
| "\n", | |||
| "Only the `search` module is in sat-search is used as a library, and it contains a single class, `Search`. The `parser` module is used for creating a CLI parser, and `main` contains the main function used in the CLI.\n", | |||
| "\n", | |||
| "**API endpoint**: Sat-search uses an endpoint defined by the SATUTILS_API_URL environment variable. This defaults to https://sat-api.developmentseed.org/ but can point to any STAC compatible endpoint." | |||
| "**API endpoint**: Sat-search uses an endpoint defined by the STAC_API_URL environment variable. This defaults to https://earth-search.aws.element84.com/v0 but can point to any STAC compatible endpoint." | |||
|
couple changes needed. Tests are failing because there is no default URL provided for tests. you can set an env variable here https://github.com/sat-utils/sat-search/blob/develop/.circleci/config.yml#L11 pointing the a viable API. |
|
Thanks @vincentsarago , I paused getting this updated because I realized I also need to fix how pagination is done to get this working with other STAC APIs, and so am updating stac-server and Earthsearch paging since am also doing that incorrectly. Once I get that deployed I'll come back and get out an rc2 of this today. |
Fix page number and url bugs
satsearch/cli.py
Outdated
| @@ -36,7 +38,7 @@ def __init__(self, *args, **kwargs): | |||
| self.output_group.add_argument('--print-md', help=h, default=None, nargs='*', dest='printmd') | |||
| h = 'Print calendar showing dates' | |||
| self.output_group.add_argument('--print-cal', help=h, dest='printcal') | |||
| self.output_group.add_argument('--print-assets', help=h, dest='printassets', default=False, action='store_true') | |||
| #h = 'Print Item Asset definition from Collections' | |||
satsearch/search.py
Outdated
|
|
||
| items = [] | ||
| found = self.found(headers=headers) | ||
| found = 0 #self.found(headers=headers) |
satsearch/search.py
Outdated
| items += [Item(i) for i in self.query(url=url, headers=headers, **kwargs)['features']] | ||
| kwargs['page'] += 1 | ||
|
|
||
| maxitems = limit #min(found, limit) |
test/test_search.py
Outdated
| Search.query(url=os.path.join(API_URL, 'collections/nosuchcollection')) | ||
| #def _test_query_bad_url(self): | ||
| # with self.assertRaises(SatSearchError): | ||
| # Search.query(url=os.path.join(API_URL, 'collections/nosuchcollection')) |
No description provided.