-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Source map 0 7 x #16
Source map 0 7 x #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't commit the package.lock
@xzyfer - FYI . amended commit here without package-lock.json . Let me know how it looks though. important: this does break backward compatibility with node.js pre-6 . FYI . Let me know if that would be ok though. |
We would need to bump the major to merge this. Can you please elaborate on
what issues the current version is causing for people?
|
Since source-map 0.6.0+ , the typings are distributed (.d.ts) within source-map package . Previously a separate types/source-map is explicitly necessary that has been deprecated since (after source-map 0.6.0 that is). FYI more here on - angular/devkit#452 - the bazel build had to be upgraded to depend on source-map 0.7.x . |
If we want to bump to a major version, do we need a separate branch for 0.x to continue with minor versions and releases , while this can go to master for the major version ? |
@xzyfer - major version bumped up given the nature of the changes involving deprecating node<6. |
@xzyfer - what would you suggest to take this one up - a separate branch ? |
Upgrade source-map to 0.7.x as needed by downstream projects