build: move notebook renderer build to esbuild #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottdover
approved these changes
Aug 30, 2023
| @@ -45,8 +45,13 @@ const nodeBuildOptions = { | |||
|
|
|||
| const browserBuildOptions = { | |||
| ...commonBuildOptions, | |||
| format: "esm", | |||
There was a problem hiding this comment.
I was about to ask if you tested the data viewer. Thanks for providing that in your testing notes :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From #482
Move notebook renderer build from webpack to esbuild, so that the
watchscript can build everything needed for Launch Client.Added
format: "esm"which is required for the notebook renderer to be invoked by VS Code engine. It looks also makes sense to DataViewer as it is currently imported as a module.Testing
client/distdirectory.Launch Clientin VS Code.