Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: (IAC-1247) Add OS Guardrail to containerd.io Task #98

Merged
merged 1 commit into from
Jan 3, 2024
Merged

fix: (IAC-1247) Add OS Guardrail to containerd.io Task #98

merged 1 commit into from
Jan 3, 2024

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented Dec 18, 2023

Changes

Add conditional to gate the Set containerd.io package debian revision if not specified task by OS

Tests

Scenario Provider K8s Version OS kubernetes_cri_version Notes
1 OSS 1.26.7 Ubuntu 22.04.3 LTS unset, default value
2 OSS 1.26.7 Ubuntu 22.04.3 LTS "1.6.20-1" task skipped since we specified deb rev
3 OSS 1.26.7 Ubuntu 20.04.6 LTS unset, default value
4 OSS 1.26.7 Ubuntu 20.04.6 LTS "1.6.20-1" task skipped since we specified deb rev

@jarpat jarpat added the bug Something isn't working label Dec 18, 2023
@jarpat jarpat self-assigned this Dec 18, 2023
thpang
thpang approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarpat jarpat merged commit ed0e56f into staging Jan 3, 2024
4 checks passed
@jarpat jarpat deleted the IAC-1247 branch January 3, 2024 19:05
@jarpat jarpat linked an issue Jan 3, 2024 that may be closed by this pull request
fix: (IAC-1247) OS Specific variables created without guardrails or OS validation #80
Closed
@jarpat jarpat mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@thpang thpang thpang approved these changes

@riragh riragh riragh approved these changes

Assignees

@jarpat jarpat

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: (IAC-1247) OS Specific variables created without guardrails or OS validation
4 participants
@jarpat @dhoucgitter @thpang @riragh