Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

K8s versioning #185

Merged
merged 9 commits into from
Nov 10, 2022
Merged

K8s versioning #185

merged 9 commits into from
Nov 10, 2022

Conversation

lasiva
Copy link
Collaborator

@lasiva lasiva commented Nov 8, 2022

There are many changes, since I have accommodated Kevin's request to rename some variables from viya_kubelet_version_min to viya_k8s_version_min.

Unit tested on AWS.

@lasiva lasiva added the enhancement New feature or request label Nov 8, 2022
@lasiva lasiva self-assigned this Nov 8, 2022
FredPerrySAS
FredPerrySAS requested changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@FredPerrySAS FredPerrySAS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment inline

@kevinlinglesas
Copy link
Collaborator

I'd also invite others to review the README file changes. Does the content cover what we need to document at this point for this enhancement? My approach was to add minimal changes necessary but to also include the support statement we discussed (@erharb , @lasiva ).

lasiva
lasiva commented Nov 8, 2022
View reviewed changes
Copy link
Collaborator Author

@lasiva lasiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the README changes,
Do we want to add something like - unless you understand the documented range please do not change VIYA_K8S-VERSION_MIN value.

kevinlinglesas
kevinlinglesas approved these changes Nov 10, 2022
View reviewed changes
Copy link
Collaborator

@kevinlinglesas kevinlinglesas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lasiva lasiva merged commit 45cd73f into develop Nov 10, 2022
@lasiva lasiva deleted the k8s_versioning branch November 10, 2022 20:11
@kevinlinglesas kevinlinglesas linked an issue Nov 15, 2022 that may be closed by this pull request
Pre-install-check tool: README update for reference Open Source K8S #181
Closed
@kevinlinglesas kevinlinglesas removed a link to an issue Nov 15, 2022
Pre-install-check tool: README update for reference Open Source K8S #181
Closed
@kevinlinglesas kevinlinglesas linked an issue Nov 15, 2022 that may be closed by this pull request
Pre-install check: Tool update to check the Kubernetes version minimum for SAS Viya #184
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredPerrySAS FredPerrySAS FredPerrySAS approved these changes

@kevinlinglesas kevinlinglesas kevinlinglesas approved these changes

@erharb erharb Awaiting requested review from erharb

@sasjowood sasjowood Awaiting requested review from sasjowood

Assignees

@lasiva lasiva

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre-install check: Tool update to check the Kubernetes version minimum for SAS Viya
3 participants
@lasiva @kevinlinglesas @FredPerrySAS