Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(#171) Remove the check for kubectl api-resources #172

Merged
merged 1 commit into from
Jun 14, 2022
Merged

(#171) Remove the check for kubectl api-resources #172

merged 1 commit into from
Jun 14, 2022

Conversation

lasiva
Copy link
Collaborator

@lasiva lasiva commented Jun 9, 2022

No description provided.

@lasiva lasiva added the bug Something isn't working label Jun 9, 2022
@lasiva lasiva requested review from kevinlinglesas and erharb June 9, 2022 13:43
@lasiva lasiva self-assigned this Jun 9, 2022
@lasiva lasiva requested a review from sasjowood June 9, 2022 13:46
kevinlinglesas
kevinlinglesas approved these changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@kevinlinglesas kevinlinglesas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me based on prior discussion of what to expect.

sasjowood
sasjowood approved these changes Jun 9, 2022
View reviewed changes
Copy link
Collaborator

@sasjowood sasjowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@kevinlinglesas kevinlinglesas linked an issue Jun 14, 2022 that may be closed by this pull request
Pre Install Checker Reports Namespace Admin Permissions - Insufficient. #171
Closed
@lasiva lasiva merged commit 1d13347 into develop Jun 14, 2022
@kevinlinglesas kevinlinglesas deleted the issue_171 branch October 7, 2022 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sasjowood sasjowood sasjowood approved these changes

@kevinlinglesas kevinlinglesas kevinlinglesas approved these changes

@erharb erharb Awaiting requested review from erharb

Assignees

@lasiva lasiva

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pre Install Checker Reports Namespace Admin Permissions - Insufficient.
3 participants
@lasiva @kevinlinglesas @sasjowood