Issue 164: Pre_Install_Report : Update deprecated Kubernetes APIs in tool to be compatible with Viya supported range 1.20.x-1.22.x #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasiva
changed the title
sasjowood
reviewed
Jan 19, 2022
FredPerrySAS
approved these changes
Jan 21, 2022
lasiva
changed the title
| curr_version = semantic_version.Version(str(self._k8s_server_version)) | ||
|
|
||
| if(curr_version in semantic_version.SimpleSpec(viya_constants.MIN_K8S_SERVER_VERSION)): | ||
| self.logger.error("This release of Kubernetes is not supported. major {} minor {}" |
There was a problem hiding this comment.
Is this log entry show up as "This release of Kubernetes is not supported. X Y" rather than "X.Y"?? Seems like it's coded for the former but should be the latter.
There was a problem hiding this comment.
Modified code so that the output looks like this: Example "This release of Kubernetes is not supported 1.16.x"
There was a problem hiding this comment.
Just saying what is not supported is not clear enough, does somewhere else in the messaging or report output clarify what the minimum supported version is to go along with the statement?
kevinlinglesas
approved these changes
Jan 26, 2022
sasjowood
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates:
Deleted support for <1.19.
Questions:
There are no checks for upper limit of k8s supported range. Do we need one ???