Skip to content

Commit

Permalink
msi: don't change the revision of the CDF container
Browse files Browse the repository at this point in the history
Don't remember why this was originally done, and most of the time it's
fine, but some MSIs with a particular unknown quirk will fail to be
recognized as signed if the revision is changed. There also seems to be
something weird going on with the Reserved1 field.
  • Loading branch information
mtharp committed May 2, 2018
1 parent 3997bf2 commit 7df4e45
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions lib/comdoc/writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -101,10 +101,6 @@ func (r *ComDoc) Close() error {
// Write file header
copy(r.Header.Magic[:], fileMagic)
r.Header.ByteOrder = byteOrderMarker
if r.Header.Revision != 0 && r.Header.Version != 0 {
r.Header.Revision = 0x3e
r.Header.Version = 0x3
}
r.Header.SATSectors = uint32(len(satList))
r.Header.MSATSectorCount = uint32(len(msatList))
buf := bytes.NewBuffer(make([]byte, 0, 512))
Expand Down

0 comments on commit 7df4e45

Please sign in to comment.