Add variable scope tests (globals and defaults)

[mgreter]

Spec tests for feature PR sass/libsass#986

[xzyfer]

FYI there is already a very thorough PR for this
On 27 Mar 2015 06:10, "Marcel Greter" [email protected] wrote:

Spec tests for feature PR sass/libsass#986

sass/libsass#986

You can view, comment on, or merge this pull request online at:

#282
Commit Summary

• Add variable scope tests (globals and defaults)

File Changes

• A
  spec/libsass-todo-tests/variable-scoping/defaults/expected.compact.css
  https://github.com/sass/sass-spec/pull/282/files#diff-0 (6)
• A
  spec/libsass-todo-tests/variable-scoping/defaults/expected.compressed.css
  https://github.com/sass/sass-spec/pull/282/files#diff-1 (1)
• A
  spec/libsass-todo-tests/variable-scoping/defaults/expected.expanded.css
  https://github.com/sass/sass-spec/pull/282/files#diff-2 (24)
• A
  spec/libsass-todo-tests/variable-scoping/defaults/expected_output.css
  https://github.com/sass/sass-spec/pull/282/files#diff-3 (20)
• A spec/libsass-todo-tests/variable-scoping/defaults/input.scss
  https://github.com/sass/sass-spec/pull/282/files#diff-4 (31)
• A
  spec/libsass-todo-tests/variable-scoping/lexical-scope/expected.compact.css
  https://github.com/sass/sass-spec/pull/282/files#diff-5 (2)
• A
  spec/libsass-todo-tests/variable-scoping/lexical-scope/expected.compressed.css
  https://github.com/sass/sass-spec/pull/282/files#diff-6 (1)
• A
  spec/libsass-todo-tests/variable-scoping/lexical-scope/expected.expanded.css
  https://github.com/sass/sass-spec/pull/282/files#diff-7 (21)
• A
  spec/libsass-todo-tests/variable-scoping/lexical-scope/expected_output.css
  https://github.com/sass/sass-spec/pull/282/files#diff-8 (19)
• A spec/libsass-todo-tests/variable-scoping/lexical-scope/input.scss
  https://github.com/sass/sass-spec/pull/282/files#diff-9 (19)
• A
  spec/libsass-todo-tests/variable-scoping/root-scope/expected.compact.css
  https://github.com/sass/sass-spec/pull/282/files#diff-10 (2)
• A
  spec/libsass-todo-tests/variable-scoping/root-scope/expected.compressed.css
  https://github.com/sass/sass-spec/pull/282/files#diff-11 (1)
• A
  spec/libsass-todo-tests/variable-scoping/root-scope/expected.expanded.css
  https://github.com/sass/sass-spec/pull/282/files#diff-12 (21)
• A
  spec/libsass-todo-tests/variable-scoping/root-scope/expected_output.css
  https://github.com/sass/sass-spec/pull/282/files#diff-13 (19)
• A spec/libsass-todo-tests/variable-scoping/root-scope/input.scss
  https://github.com/sass/sass-spec/pull/282/files#diff-14 (17)

Patch Links:

• https://github.com/sass/sass-spec/pull/282.patch
• https://github.com/sass/sass-spec/pull/282.diff

—
Reply to this email directly or view it on GitHub
#282.

[mgreter]

OK, can you give a link? I'm pretty much done by now!
Sorry, thought this was the libsass PR. Maybe we can combine them!

[xzyfer]

#244
On 27 Mar 2015 08:13, "Marcel Greter" [email protected] wrote:

OK, can you give a link? I'm pretty much done by now!

—
Reply to this email directly or view it on GitHub
#282 (comment).

[mgreter]

Just tested and all tests pass with the open PR at sass/libsass#986. Also squashed @hugogiraudel commits into this PR so I could test them at the same time (and re-generated to test all output styles)!