Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Remove use of 'package' as a variable name in install.js #936

Merged
merged 1 commit into from
May 8, 2015

Conversation

apiv
Copy link

@apiv apiv commented May 7, 2015

package is a reserved word in strict mode. Therefore, node-sass cannot be packaged by a bundler that forces strict mode.

This pull request removes the package keyword, and renames the variable to pkg, as it is in scripts/build.js.

@xzyfer
Copy link
Contributor

xzyfer commented May 8, 2015

Thanks @ajp427 !

@xzyfer xzyfer added this to the next.patch milestone May 8, 2015
xzyfer added a commit that referenced this pull request May 8, 2015
Remove use of 'package' as a variable name in install.js
@xzyfer xzyfer merged commit a5ff5d6 into sass:master May 8, 2015
@xzyfer xzyfer modified the milestones: next.patch, v3.1.0 May 13, 2015
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this pull request Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants