Move logic that sets sourceMap path if the sourceComment was "map" to sass.js

[adamyeats-zz]

Fixes #245. Oh yeah!

[andrew]

Nice work, would be great if we had a test for this too?

[adamyeats-zz]

Agreed, there are tests for this in test/cli.js, which can be moved out elsewhere.

[adamyeats-zz]

Looks like there's still a bit of work that needs to be done before this patch can be merged, will take a look tomorrow.

[andrew]

@adamyeats did you make a decision on this yet?

[keithamus]

@adamyeats any update on this PR? Looks like it might need a rebase.

[adamyeats-zz]

@andrew @keithamus Apologies for the delay in replying. Here's what needs to be done on this:

• Needs a test
• Needs a second opinion on my last comment on Set the sourceMap path if the sourceComment was 'map' #245

I'll rebase the branch and look to add a test this weekend. Can I ask someone to have a look at #245 for advice on how to proceed?

[andrew]

@adamyeats for #245, I think throw is probably the right approach at the moment, we can always change it later if someone wants to put lots more work in.

[andrew]

@adamyeats can has rebase?

[andrew]

Going to close this out as it's conflicting and @adamyeats hasn't got much time to finish it up at the moment