Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

installation failes on windows : --msvs_version npm flag ignored during binding build #122

Merged
merged 1 commit into from
Jul 12, 2013

Conversation

silver83
Copy link
Contributor

When installing via npm with the "--msvs_version" option, it is ignored.

This is due to custom install script in package.json, which should be replaced with the automatic node-gyp call performed by npm which passes the option automatically.

npm searches for binding.gyp and automatically calls node-gyp with the appropriate options.
(https://npmjs.org/doc/json.html)

@andrew
Copy link
Contributor

andrew commented Jul 12, 2013

Looks great, thanks!

andrew added a commit that referenced this pull request Jul 12, 2013
installation failes on windows : --msvs_version npm flag ignored during binding build
@andrew andrew merged commit 6b416e9 into sass:master Jul 12, 2013
@andrew
Copy link
Contributor

andrew commented Jul 12, 2013

I've had to revert this as there are issues for users on windows installing node-sass as a dependency: #123

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants