Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Add in support for debug information in the output css files. #116

Merged
merged 2 commits into from
Jul 2, 2013
Merged

Add in support for debug information in the output css files. #116

merged 2 commits into from
Jul 2, 2013

Conversation

fourseven
Copy link
Contributor

Hi all, I've added in the ability to turn on output comments, as either inline maps or source line comments. Since it's referring to source files it only makes sense when a file is passed in, and is ignored if you use the data/string options.

@andrew
Copy link
Contributor

andrew commented Jun 30, 2013

Great! Looks like there are a couple test failures on travis, if you can fix them up I'll merge it in.

Cheers
Andrew

@fourseven
Copy link
Contributor Author

Does travis rebuild the binaries? The same tests work locally - is there something I'm missing?

@andrew
Copy link
Contributor

andrew commented Jun 30, 2013

Ah yes, sorry I'm not really awake yet!

@fourseven
Copy link
Contributor Author

I've removed the darwin-specific catch on rebuild.js so that it will be rebuilt by travis. I'm not entirely sure why it was there, if there's a reason I'd be intrigued to know more.

@andrew
Copy link
Contributor

andrew commented Jul 2, 2013

I don't remember why it's there tbh, I'll merge it in and see how it goes, we can always revert it later.

andrew added a commit that referenced this pull request Jul 2, 2013
Add in support for debug information in the output css files.
@andrew andrew merged commit 1d397cc into sass:master Jul 2, 2013
@bobrocke
Copy link

bobrocke commented Jul 2, 2013

OK! So how do you tell it you want your CSS output with the debugger info, or not?

@fourseven
Copy link
Contributor Author

@bobrocke there's documentation in the readme as part of the pull request, it's added the sourceComments option, which can be 'none', for standard behaviour, 'normal' for comments with line numbers, and 'map' for @media style debug info. Bear in mind that the npm module hasn't been updated yet, so it'll only work from source at the moment.

@andrew
Copy link
Contributor

andrew commented Jul 12, 2013

I've had to revert the building on every platform as there are issues for users on windows installing node-sass as a dependency: #123

@@ -21,26 +21,35 @@ var SASS_OUTPUT_STYLE = {
compressed: 3
};

var SASS_SOURCE_COMMENTS = {
none: 0,
// This is called default in libsass, but is a reserved keyword here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not true. It was for ES3, but this is Node (ES5), so you shouldn't have to care.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants