This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
Don't compile delay hook into libsass #1147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@am11 it seems that the delay hook gets compiled by default into every gyp target. We certainly don't need in the libsass part, we only need it in the main module. Can you check if we still can link at runtime to |
Windows delay hook feature is only needed on the main module, linked into the shared library. Don't compile and include it second time in the bundled libsass. Related: nodejs/node-gyp#732
|
Tested with iojs v3.3.1 and its alias |
This was referenced Oct 16, 2015
jiongle1
pushed a commit
to scantist-ossops-m2/node-sass
that referenced
this pull request
Apr 7, 2024
Allow more valid ascii chars for url parsing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Windows delay hook feature is only needed
on the main module, linked into the shared
library. Don't compile and include
it second time in the bundled libsass.
Related: nodejs/node-gyp#732