Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Investigate CMake.js for build #935

Closed
nschonni opened this issue May 7, 2015 · 7 comments
Closed

Investigate CMake.js for build #935

nschonni opened this issue May 7, 2015 · 7 comments

Comments

@nschonni
Copy link
Contributor

nschonni commented May 7, 2015

Came across this the other day as a alternate for the node-gyp/pan-gyp problems.
https://www.npmjs.com/package/cmake-js

I had looked at this for libsass awhile ago in sass/libsass#616 but I've been pretty absent from development for the last while.

@unbornchikken
Copy link

Hi there,

I'm the author of the mentioned package. Let me know if you need help with this.

@am11
Copy link
Contributor

am11 commented May 10, 2015

Let me know if you need help with this.

A PR would be much appreciated! ☀️ 😎

@unbornchikken
Copy link

What's the actual issue are you having at node-sass side? If I PR a CMakeLists.txt, that's gonna be based on that I am seeing in binding.gyp file, not the libsass' makefile. So if you're having issues because gyp is ain't capable to do something that makefile does, then my PR migt not solve this. I simply don't have time to analize and deconstruct libsass source and its makefile, sorry. Converting the gyp file is achievable.

@saper
Copy link
Member

saper commented May 11, 2015

Well, libsass can be compiled in a Makefile-only (poor man's mode) configuration as well as with a full-blown autoconf

node-gyp/pangyp problem relates to the issues mostly outside of the building system, like linking to a proper binary name on Windows (see #945 and friends)

@unbornchikken
Copy link

Yeah. I think io.js guys had to be stick with node.exe only. There is no good solution for this, that delay load hack that *.gyp uses doesn't work in every situation. Unfortuanatelly CMake.js can't help with that. Io.js modules of course builds flawlessly, but they are stick with iojs.exe, not node.js exe, so things like mocha.cmd or npm test will break, like with pangyp.

I hope for node and io.js reunion.

However, makefile to CMakeList.txt is doable. So there can be node-sass that compiles on every os and node compatible platforms, without using anything that have to be precompiled. Will it make you happier than you're today with gyp or won't?

@xzyfer
Copy link
Contributor

xzyfer commented May 12, 2015

I'm curious as to what the benefit you see here is @nschonni?

Is this just change for the sake of change, or is there a real world gain to be had?

@unbornchikken
Copy link

Yeah, I'm too. I still don't get what's the actual issue that CMake or CMake.js could solve there.

@xzyfer xzyfer closed this as completed May 14, 2015
jiongle1 pushed a commit to scantist-ossops-m2/node-sass that referenced this issue Apr 7, 2024
Move rpm spec file into contrib folder
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants