Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

node 13 support (Use node-sass 4.13+) #2765

Closed
3 tasks done
saper opened this issue Oct 22, 2019 · 15 comments
Closed
3 tasks done

node 13 support (Use node-sass 4.13+) #2765

saper opened this issue Oct 22, 2019 · 15 comments

Comments

@saper
Copy link
Member

saper commented Oct 22, 2019

Node 13.0.0 is out.

node-sass does not support node 13 yet.

@saper
Copy link
Member Author

saper commented Oct 22, 2019

Good news - just built node 13 from source and it looks like we have no issues compiling our binding:

  rm -rf "Release/binding.node" && cp -af "Release/obj.target/binding.node" "Release/binding.node"
gmake: Leaving directory '/home/saper/node_modules/node-sass/build'
gyp info ok 
Installed to /home/saper/node_modules/node-sass/vendor/freebsd-x64-79/binding.node

@timmay7
Copy link

timmay7 commented Oct 22, 2019

+1 to this report. NodeJS 13 just recently released and does not play well with node-sass.

@saper
Copy link
Member Author

saper commented Oct 23, 2019

It does play well. #2766 is probably ready to go.

@justmedanny
Copy link

I hope that it does play well and the issue I'm having is only local to me. I'm on node 13.0.1 and I'm getting the error:

Downloading binary from https://github.com/sass/node-sass/releases/download/v4.12.0/win32-x64-79_binding.node
Cannot download "https://github.com/sass/node-sass/releases/download/v4.12.0/win32-x64-79_binding.node":

HTTP error 404 Not Found

Hint: If github.com is not accessible in your location
try setting a proxy via HTTP_PROXY, e.g.

  export HTTP_PROXY=http://example.com:1234

or configure npm proxy via

  npm config set proxy http://example.com:8080

@saper
Copy link
Member Author

saper commented Oct 23, 2019

@justmedanny This is what this bug is about. node-sass does not currently ship ready to use binaries for node 13.

@saper
Copy link
Member Author

saper commented Oct 24, 2019

Please upgrade to node-sass 4.13.0 when using node 13. Thank you!

@saper saper closed this as completed Oct 24, 2019
@mrpapercut
Copy link

mrpapercut commented Oct 24, 2019

Thank you for your work. Sadly, the one release I need is missing: linux_musl-x64-79_binding.node for version 4.13.0, which is the version needed in Alpine Linux

@nschonni
Copy link
Contributor

Yeah, looks like the Alpine bindings are missing

@nschonni nschonni reopened this Oct 24, 2019
@saper
Copy link
Member Author

saper commented Oct 24, 2019

How do we build them? Docker something something?

@nschonni
Copy link
Contributor

The instructions linked to #1996 might still be correct

@saper
Copy link
Member Author

saper commented Oct 24, 2019

Thanks, I think I got it working ... Trying to build now

@saper
Copy link
Member Author

saper commented Oct 24, 2019

@mrpapercut @ramiel node-sass binary for Alpine Linux running node 13 has been uploaded, please check

@nschonni
Copy link
Contributor

Thanks @saper ! I keep meaning to at least add the Alpine build into the release build matrix, but haven't gotten to it.
Closing since the bindings should all be there again

@nschonni nschonni changed the title node 13 support node 13 support (Use node-sass 4.13+) Oct 24, 2019
@saper
Copy link
Member Author

saper commented Oct 24, 2019

Thank you!

@electriquo
Copy link

@saper \ @nschonni: thank you! works for me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants