Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SourceMap: Fixes relative file path issue #964

Merged
merged 1 commit into from
Mar 18, 2015
Merged

SourceMap: Fixes relative file path issue #964

merged 1 commit into from
Mar 18, 2015

Conversation

am11
Copy link
Contributor

@am11 am11 commented Mar 18, 2015

This fixes the issue described here: sass/node-sass#764.

When output_path is set as absolute path, the path should be resolved with respect to map file path for emitter.

@am11
Copy link
Contributor Author

am11 commented Mar 18, 2015

With this change, node-sass passes all 749 tests. (and without it, nine source-map related tests were failing)

@xzyfer, would it be possible to release libsass-v3.0.0-beta.2, so we can release node-sass v3.0.0-alpha.1 with all the awesome libsass new features? (-8

@coveralls
Copy link

Coverage Status

Coverage remained the same at 80.72% when pulling 8f36c75 on am11:master into 4217540 on sass:master.

@xzyfer xzyfer added this to the 3.2 milestone Mar 18, 2015
xzyfer added a commit that referenced this pull request Mar 18, 2015
Fixes sourcemaps relative file path issue
@xzyfer xzyfer merged commit 62314f6 into sass:master Mar 18, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Mar 18, 2015

@am11
Copy link
Contributor Author

am11 commented Mar 18, 2015

@xzyfer, thank you! 👍 🎉

@am11
Copy link
Contributor Author

am11 commented Mar 18, 2015

Now, I would just need to attempt the code to compile against gcc 4.4.7 on o0ooold CentOS! 8-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants