Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement third party plugin loader #919

Merged
merged 1 commit into from
Mar 6, 2015
Merged

Implement third party plugin loader #919

merged 1 commit into from
Mar 6, 2015

Conversation

mgreter
Copy link
Contributor

@mgreter mgreter commented Mar 5, 2015

This is a first working draft to address #878
Also added an example plugin to this branch!

libsass-plugins-2

Build currently fails because of sassc: sass/sassc#98

This was referenced Mar 5, 2015
Merged
Closed
@mgreter mgreter force-pushed the feature/plugin-functions branch 6 times, most recently from 95535d0 to eb1ba11 Compare March 5, 2015 18:53
@mgreter mgreter changed the title [WIP] Implement third party plugin loader Implement third party plugin loader Mar 5, 2015
@mgreter mgreter added this to the 3.2 milestone Mar 5, 2015
@mgreter
Copy link
Contributor Author

mgreter commented Mar 5, 2015

IMHO this is ready to be merged since it compiles fine in all CI build!
I would like to mark this feature as experimental and include it in 3.2!

@xzyfer
Copy link
Contributor

xzyfer commented Mar 5, 2015

I think you should move the example plugin out of root i.e. /examples/plugin/basic.cpp

Otherwise 👍

@mgreter
Copy link
Contributor Author

mgreter commented Mar 6, 2015

Actually I intended to remove it before I remove the WIP tag ...

@xzyfer
Copy link
Contributor

xzyfer commented Mar 6, 2015

That'll work also
On 6 Mar 2015 16:57, "Marcel Greter" [email protected] wrote:

Actually I intended to remove it before I remove the WIP tag ...

—
Reply to this email directly or view it on GitHub
#919 (comment).

@mgreter
Implement third party plugins loader
eda5558 
Currently only for custom functions.
More features to be added later ...
@mgreter
Copy link
Contributor Author

mgreter commented Mar 6, 2015

I've removed the sample files. Will add the code to the wiki once this is merged!

@mgreter mgreter self-assigned this Mar 6, 2015
mgreter added a commit that referenced this pull request Mar 6, 2015
@mgreter
Merge pull request #919 from mgreter/feature/plugin-functions
dd4187a 
Implement third party plugin loader
@mgreter mgreter merged commit dd4187a into sass:master Mar 6, 2015
@mgreter mgreter deleted the feature/plugin-functions branch March 6, 2015 22:57
@xzyfer
Copy link
Contributor

xzyfer commented Mar 7, 2015

Awesome work @mgreter

@am11 am11 mentioned this pull request Mar 11, 2015
Closed
@lunelson
Copy link

This is a super exciting feature if it does what I think. Would this be a means to add advanced math functions, for example?

Example plugin link above is 404.

@mgreter
Copy link
Contributor Author

mgreter commented Mar 12, 2015

Yep, you could create a dll with various custom (math) functions to be loaded by libsass.

@scottkellum scottkellum mentioned this pull request Mar 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mgreter mgreter

Labels
None yet
Projects
None yet
Milestone
3.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mgreter @xzyfer @lunelson