Refactor output emitter and implement missing output styles

[mgreter]

This superseeds #899

Related to sass/sass-spec#270 and sass/sassc#97

• Heavily refactored output code
• Should make source maps more reliable
• Output styles are mostly done in emitter.cpp
• Refactored Parser (added new String type)
• Interpolation should now work as with ruby sass
• Commented out obsolete code (missing spec tests?)

Fixes

• libsass doesn't preserve new lines in nested style (Ruby Sass does) #552 libsass doesn't preserve newlines
• Interpolation inside an interpolation isn't handled correctly #615 Interpolation inside an interpolation isn't handled correctly
• Interpolation mangles up lists #639 Interpolation mangles up lists
• Interpolation of quoted strings differs from Ruby SASS #694 Interpolation of quoted strings differs from Ruby SASS
• Fix string-interpolation of lists, and normalization of string-quoting #870 Fix string-interpolation of lists, and normalization of string-quoting
• Interpolations are parsed incorrectly #876 Interpolations are parsed incorrectly
• Support 'compact' output style. #838 Support 'compact' output style
• SASS_STYLE_COMPRESSED fails to eliminate empty rules with comments #894 SASS_STYLE_COMPRESSED fails to eliminate empty rules with comments
• libsass-todo-tests/186 and libsass-todo-tests/scss-tests/172
• partially libsass-todo-tests/css_nth_selectors

[mgreter]

@xzyfer IMHO this is ready to be merged! Anything speaking against it from your side? What do you think about the changes in the spec-test? Really hope everything is still in order 😅

[xzyfer]

The only think that jumped out at me is sass/sass-spec#270 (comment). Otherwise 👍

[am11]

👍

[am11]

AppVeyor builds are failing for VC jobs: https://ci.appveyor.com/project/sass/libsass/build/1.0.200.

Adding output_nested and output_compressed in win/libsass.vcxproj and applying the following patch would fix it:

diff --git a/inspect.cpp b/inspect.cpp
index d58dd3c..f3998b1 100644
--- a/inspect.cpp
+++ b/inspect.cpp
@@ -6,6 +6,7 @@
 #include <string>
 #include <iostream>
 #include <iomanip>
+#include <stdint.h>

[mgreter]

@am11 I've added the additional header you mentioned in your comment above, but output_nested and output_compressed have been removed actually (or I did not understand your comment)!

[am11]

@mgreter, yes actually the error was about files not found (because they were referenced in vcxproj but were removed from repo). 😃

It is now complaining that we need #include<stdint.h> in util.cpp.
https://ci.appveyor.com/project/sass/libsass/build/1.0.207/job/bbhkel9xigunkppk#L950

Would it make sense to add headers in .hpps, so when the header is used by multiple .cpp, it shares forward declarations for those lang features?

[coveralls]

Coverage increased (+0.94%) to 80.67% when pulling 7877cfa on mgreter:feature/output-emitter into f642fad on sass:master.

[am11]

All Green! https://ci.appveyor.com/project/sass/libsass/build/1.0.208.
Yay! 🎉

[mgreter]

Thanks for the help with the appveyor ci build! 🚀

[am11]

@mgreter, there are around 266 warnings in VC job on AppVeyor. Some warnings are ignorable (POSIX style vs. STD-C++ style like _stdrup).
But others may be useful. Like there are 100+ warnings with code C4099: https://msdn.microsoft.com/en-us/library/695x5bes.aspx.

'Sass::Context' : type name first seen using 'struct' now seen using 'class'

(and vice versa)

For instance, in bind.hpp you have struct Context, while elsewhere it is used as class. Would it be a good idea to visit those warnings, it might improve some code patterns. :)

[mgreter]

Maybe someone that actually uses MSVC could create a patch to solve these warnings? Beside a struct is principally just a class with all variables defined as public ... but wouldn't hurt to get rid of these. We also do have a copy_c_str function which could act as a replacement for strdup.

[mgreter]

Since nobody has any objections against it, I'm going to hit "merge" here in a few minutes!

[am11]

Sure. I will try to take a stab at those soon. 😃

[xzyfer]

Amazing work @mgreter !!