Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: non-integers passed to str-slice #2949

Merged
merged 1 commit into from
Jul 26, 2019
Merged

fix: non-integers passed to str-slice #2949

merged 1 commit into from
Jul 26, 2019

Conversation

nschonni
Copy link
Collaborator

@nschonni nschonni force-pushed the fix--non-integers-passed-to-str-slice branch from 63988e4 to 44e7a9e Compare July 18, 2019 05:40
@nschonni nschonni requested a review from mgreter July 19, 2019 00:28
mgreter
mgreter approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@mgreter mgreter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@nschonni nschonni merged commit eb54de6 into sass:master Jul 26, 2019
@nschonni nschonni deleted the fix--non-integers-passed-to-str-slice branch July 26, 2019 02:33
@nschonni nschonni mentioned this pull request Sep 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgreter mgreter mgreter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

str-slice() should require integer indexes
2 participants
@nschonni @mgreter