-
Notifications
You must be signed in to change notification settings - Fork 462
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes another memory leak and improves travis config #2753
Conversation
ALPHA_NUM throws on invalid argument. When this happened, `new_c` was never freed.
Can't figure out why it's failing the Some memory leaks are reported in plugins. I've sent the following PRs: mgreter/libsass-glob#1 For |
@mgreter I've fixed all the memory leaks reported in the plugins. Can you please merge the PRs? |
Hi @glebm, will do once I get back home from knee surgery, might take a few more days. Best regards and thanks for your work. |
@mgreter Sorry to hear about your surgery. Forget about GitHub and focus on recovering! I hope you get better soon! Thank you for letting us know. |
@glebm Merged all your PRs so you can continue to get ASAN build green :) Thanks for your work and looking forward to confirm it all myself once I'm a bit more mobile again 👍 |
Kicked off a rebuild if master. Looks there are compilation failures in the plugin tests. I'm out at dinner so I can't look into it any further ATM. |
It is finally green! #2760 |
🎉
…On Sun., 25 Nov. 2018, 11:51 am Gleb Mazovetskiy ***@***.*** wrote:
It is finally green! #2760 <#2760>
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#2753 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAjZWEJl_fHPRrD91DkuNW1UdmKNPlAjks5uyemagaJpZM4YsPwL>
.
|
ASAN_OPTIONS
work-around for ODR violation red herring caused by https://bugs.llvm.org/show_bug.cgi?id=37545.This still doesn't completely fix the Travis ASan build but it brings us much closer.