Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes another memory leak and improves travis config #2753

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Conversation

glebm
Copy link
Contributor

@glebm glebm commented Nov 21, 2018

  1. Fixes another memory leak.
  2. Uses the default clang for ASan on Travis (v5.0) and adds an ASAN_OPTIONS work-around for ODR violation red herring caused by https://bugs.llvm.org/show_bug.cgi?id=37545.

This still doesn't completely fix the Travis ASan build but it brings us much closer.

ALPHA_NUM throws on invalid argument. When this happened, `new_c` was never freed.
@glebm
Copy link
Contributor Author

glebm commented Nov 21, 2018

Can't figure out why it's failing the error tests (and can't reproduce locally).

Some memory leaks are reported in plugins. I've sent the following PRs:

mgreter/libsass-glob#1
mgreter/libsass-digest#1
mgreter/libsass-tests#1

For libsass-tests, there is still one ASan error that I haven't figured out.

.travis.yml Show resolved Hide resolved
@xzyfer xzyfer merged commit 754b338 into sass:master Nov 21, 2018
@glebm glebm deleted the fixes branch November 21, 2018 10:59
@glebm
Copy link
Contributor Author

glebm commented Nov 21, 2018

@mgreter I've fixed all the memory leaks reported in the plugins. Can you please merge the PRs?

@mgreter
Copy link
Contributor

mgreter commented Nov 21, 2018

Hi @glebm, will do once I get back home from knee surgery, might take a few more days. Best regards and thanks for your work.

@glebm
Copy link
Contributor Author

glebm commented Nov 21, 2018

@mgreter Sorry to hear about your surgery. Forget about GitHub and focus on recovering! I hope you get better soon! Thank you for letting us know.

@mgreter
Copy link
Contributor

mgreter commented Nov 24, 2018

@glebm Merged all your PRs so you can continue to get ASAN build green :) Thanks for your work and looking forward to confirm it all myself once I'm a bit more mobile again 👍

@xzyfer
Copy link
Contributor

xzyfer commented Nov 24, 2018

Kicked off a rebuild if master. Looks there are compilation failures in the plugin tests. I'm out at dinner so I can't look into it any further ATM.

https://travis-ci.org/sass/libsass/builds/458739532

@glebm
Copy link
Contributor Author

glebm commented Nov 24, 2018

Sent mgreter/libsass-tests#2

@glebm
Copy link
Contributor Author

glebm commented Nov 25, 2018

It is finally green! #2760

@xzyfer
Copy link
Contributor

xzyfer commented Nov 25, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants