Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

& interpolation in selector causes segfault #978

Closed
xzyfer opened this issue Mar 23, 2015 · 5 comments · Fixed by #1003
Closed

& interpolation in selector causes segfault #978

xzyfer opened this issue Mar 23, 2015 · 5 comments · Fixed by #1003

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Mar 23, 2015

This causes a segfault on the latest master.

.foo {
  [baz="#{&}"] {
    foo: bar;
  }
}

Results in

[1] 37755 segmentation fault sassc test.scss

/cc @ekskimn this may be of interest to you.

@ekskimn
Copy link

ekskimn commented Mar 23, 2015

@xzyfer Taking a look....

@ekskimn
Copy link

ekskimn commented Mar 23, 2015

@xzyfer Just a quick update....i did some debugging and the error occurs in the eval visitor when visiting the parent selector, after doing the contextualize visitation and before executing any of the listize visitations. It isn't in the static cast, because I broke that out into its own line and it got passed that just fine. Somehow it is blowing up when calling perform(listize) but not sure why yet.

@xzyfer
Copy link
Contributor Author

xzyfer commented Mar 28, 2015

I started looking at this last week. I've been bogged down this week but I think I'm close. I'll take a look this weekend.

@mgreter
Copy link
Contributor

mgreter commented Mar 28, 2015

IMHO the bug occurs because fallback somewhere is returning parent which is null in this case. Bit I wasn't able to further debug into it, so not sure if this really is the problem. Edit: this is happening in Contextualize::fallback_impl.

@mgreter mgreter assigned mgreter and unassigned xzyfer Mar 29, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Mar 29, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Mar 29, 2015
@ekskimn
Copy link

ekskimn commented Mar 31, 2015

@mgreter Thanks Marcel~! I didnt' get a chance to look at this further~!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants