3.3.3 regression with &:not(...)

[asottile]

Input:

a, b {
    &:not(c) {
        d: e;
    }
}

libsass 3.3.2

a:not(c), b:not(c) {
  d: e; }

libsass 3.3.3

a:not(c, c), b:not(c, c) {
  d: e; }

ruby-sass 3.4.20: https://gist.github.com/asottile/262b30c2d4e41b88dfd2

[asottile]

bisect tells me this is the first commit showing this behaviour: 964613e @mgreter

[xzyfer]

Thanks for the report @asottile. This will be addressed in 3.3.4.

[asottile]

Sounds great, I added a spec for it here: sass/sass-spec#724

[joelperry93]

I am still getting this issue.
libsass 3.3.6
node-sass 3.7.0

Can't see this ticket referenced in the release notes. Did this get fixed?

Cheers

[xzyfer]

This was fixed in 3.3.4. The output in 3.3.6 matches Ruby Sass.

a:not(c), b:not(c) {
  d: e; }

[joelperry93]

Here is my SASS and the output. Is this the same issue as this ticket describes? I am getting it on libsass 3.3.3+

SASS
[class*="button-"] { &:hover:not(.button-disabled) { transform: translate(0, 1px); } }

Invalid CSS (libsass >=3.3.3)
[class*="button-"]:hover:not(.button-disabled):not(.tablesorter-pager .button.disabled) { -webkit-transform: translate(0, 1px); transform: translate(0, 1px); }

Valid CSS (libsass <=3.3.2)
[class*="button-"]:hover:not(.button-disabled) { -webkit-transform: translate(0, 1px); transform: translate(0, 1px); }

[xzyfer]

Where is .tablesorter-pager defined. Looks like you have an extend you're
not showing. The easiest way to know if there is a bug is to compare the
LibSass output to Ruby Sass 3.4.* on sassmeister.com.
On 5 May 2016 12:10 AM, "Joel Perry" [email protected] wrote:

Here is my SASS and the output. Is this the same issue as this ticket
describes? I am getting it on libsass 3.3.3+

SASS
[class*="button-"] {
&:hover:not(.button-disabled) {
transform: translate(0, 1px);
}
}

Invalid CSS (libsass >=3.3.3)
[class*="button-"]:hover:not(.button-disabled):not(.tablesorter-pager
.button.disabled) {
-webkit-transform: translate(0, 1px);
transform: translate(0, 1px);
}

Valid CSS (libsass <=3.3.2)
[class*="button-"]:hover:not(.button-disabled) {
-webkit-transform: translate(0, 1px);
transform: translate(0, 1px);
}

—
You are receiving this because you modified the open/close state.
Reply to this email directly or view it on GitHub
#1901 (comment)

[joelperry93]

Thanks for the response. It did turn out to be an issue with that .tablesorter-pager definition in another file. The 3.3.3 update must have started compiling it correctly and causing the issue on our end. Thank you.