Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling interpolated if call #1273

Closed
ArmorDarks opened this issue Jun 12, 2015 · 1 comment
Closed

Error handling interpolated if call #1273

ArmorDarks opened this issue Jun 12, 2015 · 1 comment

Comments

@ArmorDarks
Copy link

Hi

First of all, thanks for great project!

There seems to be an issue with evolution of inline if statement.

Example:

@mixin ekzo-font($version: 1123) {

    @font-face {

        src: url(test.eot#{if($version, '?#{$version}', '')});

    }

}

In Sass produces expected output, but libsass (used via node-sass) trows following error:

>> error reading values after test

Error can be workarounded by using quotes, though:

@mixin ekzo-font($version: 1123) {

    @font-face {

        src: url('test.eot#{if($version, '?#{$version}', '')}');

    }

}
@mgreter
Copy link
Contributor

mgreter commented Jun 12, 2015

Minimal test case:

test {
  src: url(test.eot#{if(true, '?#{42}', '')});
}

expected:

test {
  src: url(test.eot?42); }

@mgreter mgreter added this to the 3.3.1 milestone Jun 13, 2015
@mgreter mgreter changed the title Error handling inline if Error handling interpolated if call Jun 13, 2015
@mgreter mgreter modified the milestones: 3.3, 3.3.1 Jun 14, 2015
@mgreter mgreter self-assigned this Jun 14, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Jun 14, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Jun 23, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Jun 30, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Jun 30, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Jun 30, 2015
xzyfer added a commit to xzyfer/sass-spec that referenced this issue Jul 8, 2015
xzyfer pushed a commit to xzyfer/libsass that referenced this issue Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants