Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adjust-color() calculates differently from Ruby Sass #1101

Closed
xzyfer opened this issue Apr 14, 2015 · 2 comments · Fixed by #1139
Closed

adjust-color() calculates differently from Ruby Sass #1101

xzyfer opened this issue Apr 14, 2015 · 2 comments · Fixed by #1139
Assignees
@mgreter
Labels
Bug - Confirmed Dev - PR Ready Dev - Test Written
Milestone
3.2

Comments

@xzyfer
Copy link
Contributor

xzyfer commented Apr 14, 2015

Originally mentioned in #1100 (comment)

$foo: white;
foo {
  bar: adjust-color($foo, $hue: -6deg, $lightness: -16, $saturation: -7);
}

Ruby Sass

foo {
  bar: #d6d6d6; }

Libsass

foo {
  bar: #d3d9d8; }
@xzyfer xzyfer added this to the 3.2.1 milestone Apr 14, 2015
@xzyfer xzyfer mentioned this issue Apr 14, 2015
Closed
@anlutro
Copy link
Contributor

anlutro commented Apr 15, 2015

Seems similar in nature to #865

@xzyfer
Copy link
Contributor Author

xzyfer commented Apr 15, 2015

@anlutro you may be correct. This code was tested and failed after that PR was merged so the issue still persists.

@xzyfer xzyfer mentioned this issue Apr 25, 2015
Closed
mgreter added a commit to mgreter/libsass that referenced this issue Apr 26, 2015
@mgreter
Add fix for hsla implementation
a278cea 
Fixes sass#1101
@mgreter mgreter mentioned this issue Apr 26, 2015
Merged
@mgreter mgreter modified the milestones: 3.2, 3.2.1 Apr 26, 2015
@mgreter mgreter self-assigned this Apr 26, 2015
mgreter added a commit to mgreter/libsass that referenced this issue Apr 27, 2015
@mgreter
Add fix for hsla implementation
79e8d32 
Fixes sass#1101
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Activate libsass todo test for issue 1101
cc34f9e 
sass/libsass#1101
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Activate libsass todo test for issue 1101
4d86b1b 
sass/libsass#1101
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Activate libsass todo test for issue 1101
3c449c4 
sass/libsass#1101
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Add todo spec test for libsass issue 1101
1d1d173 
sass/libsass#1101
mgreter added a commit to mgreter/sass-spec that referenced this issue Apr 22, 2016
@mgreter
Add todo spec test for libsass issue 1101
fc2c8c9 
sass/libsass#1101
@mgreter mgreter mentioned this issue Apr 22, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgreter mgreter

Labels
Bug - Confirmed Dev - PR Ready Dev - Test Written
Projects
None yet
Milestone
3.2
Development

Successfully merging a pull request may close this issue.

Add fix for hsla implementation mgreter/libsass
3 participants
@anlutro @mgreter @xzyfer