add first class mixins #253
Conversation
| `npm install` and then `npm run init`. This provides the following options for | ||
| `compiler` (for the embedded compiler), `protocol` (for the embedded protocol), | ||
| and `api` (for the JS API): |
There was a problem hiding this comment.
The content change here is to add "npm install and then ". The rest of the diff is reflowing to 80 characters.
|
cc @nex3 |
connorskees
force-pushed
the
feat/first-class-mixins
branch
from
24c726c
to
81cb2ad
Compare
|
I believe CI was failing because I missed adding a link to the dart-sass changes. That should now be resolved. |
|
I'm a bit confused about where the CI failure is coming from. Is there a place I'm missing updating? All relevant code touching |
|
Maybe we need to add a |
|
I made the change in sass/sass#3674, but CI fails there I believe because the spec file is in the |
|
The spec failure is due to the mismatch between |
|
Is the file in the |
As for as I know they are not auto-generated, therefore the CI has a check to ensure the documentation matches the spec. |
|
I got CI passing on the sass/sass PR if someone is able to re-run the CI for this PR |
|
The JS API steps seem to pass now, but the static analysis step is failing with an error that looks unrelated to my changes. Is the failure spurious? |
Because this repository does not have In the future, for more stable and reproducible CI runs I think we could check in |
|
#255 should fix the static analysis issues. |
…irst-class-mixins
…irst-class-mixins
Tracking issue: sass/sass#626
Protobuf changes: sass/sass#3674
Spec tests: sass/sass-spec#1933
dart-sass changes: sass/dart-sass#2073
Closes #252