Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sass-parser support for the @use rule #2389

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Add sass-parser support for the @use rule #2389

wants to merge 13 commits into from
+2,453 −42

Commits on Oct 16, 2024

  1. Add sass-parser support for the @use rule

    @nex3
    nex3 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    91cb758 View commit details
    Browse the repository at this point in the history

  2. Update other packages

    @nex3
    nex3 committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    355ee32 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Don't add spaces at the end of toCssIdentifier() 

    If this would be placed before a string that would continue the
escape, it would also continue the identifier itself.
    @nex3
    nex3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    6613bb8 View commit details
    Browse the repository at this point in the history

  2. Add tests for stringifying ConfiguredVariable 

    Also add `ConfiguredVariable.raws.name` per recent discussions.
    @nex3
    nex3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c28d3fa View commit details
    Browse the repository at this point in the history

  3. Rename ConfiguredVariable.name to variable and .value to expression 

    The original names make sense in isolation, but we want them to match
our eventual `VarriableDeclaration` class. That class will need to
have names that are sufficiently distinctive from the PostCSS
`Declaration` type, so these prefigure that naming convention.
    @nex3
    nex3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    c997979 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:sass/dart-sass into parser-use

    @nex3
    nex3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    292c821 View commit details
    Browse the repository at this point in the history

  5. Fix test failures

    @nex3
    nex3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    fbfc008 View commit details
    Browse the repository at this point in the history

  6. Reformat

    @nex3
    nex3 committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    4216c16 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Rename ConfiguredVariable.variable to .variableName 

    There's also a Declaration.variable in PostCSS u_u
    @nex3
    nex3 committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    5fad9d1 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2024

  1. Apply suggestions from code review 

    Co-authored-by: Carlos (Goodwine) <[email protected]>
    @nex3 @Goodwine
    nex3 and Goodwine authored Oct 19, 2024
    Configuration menu
    Copy the full SHA
    3878e5a View commit details
    Browse the repository at this point in the history

  2. Code review

    @nex3
    nex3 committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    65f0578 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'parser-use' of github.com:sass/dart-sass into parser-use

    @nex3
    nex3 committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    764ab63 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' of github.com:sass/dart-sass into parser-use

    @nex3
    nex3 committed Oct 19, 2024
    Configuration menu
    Copy the full SHA
    a8d887c View commit details
    Browse the repository at this point in the history