Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate protobuf as part of default task #2257

Merged
merged 1 commit into from
May 31, 2024
Merged

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented May 31, 2024

No description provided.

@nex3 nex3 requested a review from jathak May 31, 2024 21:28
@ntkme
Copy link
Contributor

ntkme commented May 31, 2024

I'm afraid that this will break linux/android release pipelines. For example, for android it builds protobuf on dart:latest container and then build the binary on ghcr.io/dart-android/dart:latest container. The reason is that there is simply no prebuilt binary of buf for android (bionic libc).

@nex3
Copy link
Contributor Author

nex3 commented May 31, 2024

I don't think those tasks use the default pub run grinder task, I think they explicitly call out to the tasks they need. The default task is really meant for human convenience.

@nex3 nex3 merged commit 53b9ead into main May 31, 2024
34 checks passed
@nex3 nex3 deleted the default-task-protobuf branch May 31, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants