Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement first class mixins #2073
implement first class mixins #2073
Changes from 27 commits
ef23769
0b9f3a8
63c1f5e
f9badfa
010ad35
b908e27
7d6757c
f715c22
c0eced3
91ac279
194e171
154e12e
ca57cb0
4093914
eb33c56
eeb14ee
1cfd14b
5e1774c
faba24a
52a1e6f
ff3d80e
89ef731
93b812a
6e85d50
2738c00
80fd8bb
9485b4f
3144e02
f1c1d5a
895b2ca
96bbca2
679e1bd
65f2d2d
75ccdfb
6277d5d
f1b4ff3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it is related to the browser failure, but I think the argument is missing
Object self
here when looking at all other values.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this does not make much sense. If I understand it correctly the reason we have this for Sass Function type is to allow the "JS" type to inherit the prototype of dart-converted-JS type? If so here the argument passed into SassMixin (the dart type) should be some argument necessary to construct an actual Mixin object.
@nex3 I don't fully understand how the JS-interop works so please correct me if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never mind. Looks like Mixin just takes AsyncCallable so this is probably fine.