Add the ability for importers to detect @import #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jathak
approved these changes
May 14, 2021
| /// Runs [callback] in a context where [inImportRule] returns `true` and | ||
| /// [resolveImportPath] uses `@import` semantics rather than `@use` semantics. | ||
| T inImportRule<T>(T callback()) => | ||
| runZoned(callback, zoneValues: {#_inImportRule: true}); |
There was a problem hiding this comment.
Is there a particular reason why this is now run in a zone, or is it just a cleaner way to update fromImport?
There was a problem hiding this comment.
Making the variable Zone-scoped means that, if multiple Sass compilations are running in parallel, they won't stomp on one another's values for this variable. It wasn't necessary before because this was only used by FileSystemImporter which was synchronous, but user-defined importers aren't necessarily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See sass/sass#3055
See webpack-contrib/sass-loader#905