Migrate to null safety (WIP) #1253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also replaces package_resolver with package_config, since package_resolver is archived and is incompatible with null-safe Dart packages.
stof
reviewed
Mar 10, 2021
| @@ -90,7 +90,7 @@ String compile(String path, | |||
| Logger logger, | |||
| Iterable<Importer> importers, | |||
| Iterable<String> loadPaths, | |||
| SyncPackageResolver packageResolver, | |||
| PackageConfig packageConfig, | |||
There was a problem hiding this comment.
is this a BC break that requires releasing it as dart-sass 2.0.0 ?
There was a problem hiding this comment.
It is, but we're only making this change because package_resolver is archived and incompatible with the latest versions of other Dart packages. Since this only affects a limited (at this point, possibly non-existent) subset of Dart API users and pub's version resolution will prevent them from updating to any version of Dart Sass that depends on the null-safe versions of these packages anyway, I think the current plan is to make this change without bumping the major version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.