Pass undefined span instead of null to Logger.warn() in JS

sass · Jan 4, 2022 · d2fc580 · d2fc580
1 parent 169178a
commit d2fc580
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,10 @@
+## 1.45.3
+
+### JS API
+
+* **Potentially breaking bug fix:** Match the specification of the new JS API by
+  passing `undefined` rather than `null` to `Logger.warn()` for an unset `span`.
+
 ## 1.45.2
 
 ### JS API

diff --git a/lib/src/logger/node_to_dart.dart b/lib/src/logger/node_to_dart.dart
@@ -2,6 +2,7 @@
 // MIT-style license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
+import 'package:node_interop/js.dart';
 import 'package:source_span/source_span.dart';
 import 'package:stack_trace/stack_trace.dart';
 import 'package:term_glyph/term_glyph.dart' as glyph;
@@ -38,7 +39,9 @@ class NodeToDartLogger implements Logger {
       warn(
           message,
           WarnOptions(
-              span: span, stack: trace.toString(), deprecation: deprecation));
+              span: span ?? (undefined as SourceSpan?),
+              stack: trace.toString(),
+              deprecation: deprecation));
     }
   }
 

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.45.2
+version: 1.45.3
 description: A Sass implementation in Dart.
 homepage: https://github.com/sass/dart-sass