Handling for non-json response #881
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #881 +/- ##
==========================================
+ Coverage 98.46% 98.85% +0.39%
==========================================
Files 24 26 +2
Lines 1364 1749 +385
==========================================
+ Hits 1343 1729 +386
+ Misses 15 14 -1
Partials 6 6 ☔ View full report in Codecov by Sentry. |
AyushSawant18588
changed the title
|
@sashabaranov Can you please look into this? |
|
Thank you for the PR! |
client_test.go
Outdated
| <hr><center>nginx</center> | ||
| </body> | ||
| </html>`, | ||
| expected: `error, status code: 413, status: , message: invalid character '<' looking for beginning of value`, |
There was a problem hiding this comment.
This expected error text is a bit misleading. Code 413 indeed points out to "Content Too Large" (generic HTTP error), but the text afterward applies to json de-serialization.
I agree that this approach is better in terms of preserving the code, but in this case we actually don't preserve data
There was a problem hiding this comment.
What if Error() for RequestError (https://github.com/sashabaranov/go-openai/blob/22cf414b4be89a38eb702b13c27be1de6bcef74d/error.go#L106C1-L108C2) is updated to return body also like:
fmt.Sprintf("error, status code: %d, status: %s, message: %s, body: %s", e.HTTPStatusCode, e.HTTPStatus, e.Err, e.Body)
Should I make this change?
There was a problem hiding this comment.
@sashabaranov I have updated this PR with the above mentioned change, now in error response the original error data is also present. Can you please review it?
|
Thanks @sashabaranov. Can you please review this again? |
Describe the change
Since the original error response is included in the body field of openai.RequestError, even when the response is not in JSON format, it would be more appropriate to return openai.RequestError directly, rather than returning an errorString. This approach ensures that the original error details are preserved within the body field.
Describe your solution
Removed the condition that checked if the response was in a non-JSON format and returned an errorString with the original error response. Now, the original error response will be directly included in the body field of openai.RequestError.