Validate sandbox and container metadata

We pre-validate the container metadata before creation the sandbox/container. Fixes kubernetes-sigs#1273 Signed-off-by: Sascha Grunert <[email protected]>
saschagrunert · Oct 9, 2023 · d96416a · d96416a
1 parent 05719b3
commit d96416a
Showing 1 changed file with 14 additions and 0 deletions.
diff --git a/cmd/crictl/util.go b/cmd/crictl/util.go
@@ -152,6 +152,13 @@ func loadContainerConfig(path string) (*pb.ContainerConfig, error) {
 	if err := utilyaml.NewYAMLOrJSONDecoder(f, 4096).Decode(&config); err != nil {
 		return nil, err
 	}
+
+	if config.Metadata == nil {
+		return nil, errors.New("metadata is not set")
+	} else if config.Metadata.Name == "" {
+		return nil, fmt.Errorf("name is not in metadata %q", config.Metadata)
+	}
+
 	return &config, nil
 }
 
@@ -166,6 +173,13 @@ func loadPodSandboxConfig(path string) (*pb.PodSandboxConfig, error) {
 	if err := utilyaml.NewYAMLOrJSONDecoder(f, 4096).Decode(&config); err != nil {
 		return nil, err
 	}
+
+	if config.Metadata == nil {
+		return nil, errors.New("metadata is not set")
+	} else if config.Metadata.Name == "" || config.Metadata.Namespace == "" || config.Metadata.Uid == "" {
+		return nil, fmt.Errorf("name, namespace or uid is not in metadata %q", config.Metadata)
+	}
+
 	return &config, nil
 }