-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance ManifestCoder
for Encoding/Decoding Routine Arguments and Returned Values
#81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvalabs-harshrastogi
requested a review
from sarvalabs-gokul
as a code owner
August 22, 2024 07:31
sarvalabs-harshrastogi
added
manifest
Issues related to manifest
logic
Module to interact with MOI Logic Objects
breaking
labels
Aug 22, 2024
sarvalabs-gokul
requested changes
Sep 4, 2024
Deploying js-moi-sdk with Cloudflare Pages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance
ManifestCoder
for Encoding/Decoding Routine Arguments and Returned ValuesImportant
This pull request has breaking changes
This pull request enhances the
ManifestCoder
class by introducing new methods and improvements to existing ones. These changes aim to simplify the process of encoding and decoding routine arguments and returned values, improving the overall developer experience.Changes:
ElementDescriptor
:ElementDescriptor
class has been relocated fromjs-moi-logic
tojs-moi-manifest
.ElementDescriptor
object with a manifest object, providing more flexibility and integration with the manifest data.ManifestCoder
:LogicManifest.Manifest
as input. (Breaking Change)Manifest.encodeArguments
:ManifestCoder.decodeArguments
:These changes streamline the process of working with routine arguments and returned values within the
ManifestCoder
class.Changes include
Checklist