-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: routine parameters mismatch bug #75
Merged
sarvalabs-harshrastogi
merged 9 commits into
sarvalabs:develop
from
0xharshrastogi:fix/routine-call-bug
Oct 24, 2024
Merged
fix: routine parameters mismatch bug #75
sarvalabs-harshrastogi
merged 9 commits into
sarvalabs:develop
from
0xharshrastogi:fix/routine-call-bug
Oct 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvalabs-harshrastogi
assigned sarvalabs-harshrastogi and unassigned sarvalabs-harshrastogi
Aug 20, 2024
Works as expected |
sarvalabs-harshrastogi
added
logic
Module to interact with MOI Logic Objects
bug
Something isn't working
labels
Aug 21, 2024
sarvalabs-gokul
requested changes
Oct 24, 2024
sarvalabs-gokul
requested changes
Oct 24, 2024
sarvalabs-gokul
approved these changes
Oct 24, 2024
This was referenced Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug "ERROR_INVALID_ARGUMENT" even after providing all necessary arguments
Description
This pull request addresses the issue described in #74. The bug occurred due to the last parameter for the routine being a
Uint8Array
of typeobject
. Same can happen with other types valuesMap
orclass
. To resolve this, a new classRoutineOptions
was created to validate the options. Additionally, a newcreateRoutineOption
function has been exposed to facilitate the creation of instances ofRoutineOptions
.Created new class
RoutineOptions
to validate routine options.Exposed
createRoutineOption
function to easily create instances ofRoutineOptions
.Closes Bug: Receiving an error stating "ERROR_INVALID_ARGUMENT" even after providing all necessary valid arguments. #74
js-moi-sdk
ReturnsNull
Instead of Response or Error when calling a endpoint #84Changes Include
Checklist