Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: routine parameters mismatch bug #75

Merged

Conversation

0xharshrastogi
Copy link

@0xharshrastogi 0xharshrastogi commented Jul 19, 2024

Fix bug "ERROR_INVALID_ARGUMENT" even after providing all necessary arguments

Description

This pull request addresses the issue described in #74. The bug occurred due to the last parameter for the routine being a Uint8Array of type object. Same can happen with other types values Map or class. To resolve this, a new class RoutineOptions was created to validate the options. Additionally, a new createRoutineOption function has been exposed to facilitate the creation of instances of RoutineOptions.

Changes Include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have updated the README and other relevant documents (guides...)

@sarvalabs-pawankalyan
Copy link

Works as expected

@sarvalabs-harshrastogi sarvalabs-harshrastogi added logic Module to interact with MOI Logic Objects bug Something isn't working labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working logic Module to interact with MOI Logic Objects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Receiving an error stating "ERROR_INVALID_ARGUMENT" even after providing all necessary valid arguments.
4 participants