refactor: simplified wallet setup #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvalabs-harshrastogi
added
enhancement
sarvalabs-harshrastogi
requested a review
from sarvalabs-gokul
as a code owner
sarvalabs-gokul
requested changes
Feb 27, 2024
Deploying with
|
| Latest commit: |
6580b6c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3f7b620d.js-moi-sdk.pages.dev |
| Branch Preview URL: | https://refactor-wallet-initializati.js-moi-sdk.pages.dev |
sarvalabs-gokul
approved these changes
Feb 27, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified Wallet Setup and Initialization
This pull request introduces significant enhancements to the
js-moi-walletmodule, simplifying the wallet setup and initialization APIs for a more user-friendly experience.Changes
The following key changes have been implemented:
constructor: Now, a Wallet instance is created using the private key, serving as both the creation and initialization step.Wallet.fromMnemonic: Enables the creation of a wallet using a mnemonic and a specified path.Wallet.fromMnemonicSync: Synchronously creates a wallet using a mnemonic and a path.Wallet.fromKeystore: Allows the creation of a wallet instance using a provided keystore and password.Wallet.createRandom: Introduces a method to create a wallet instance using a randomly generated mnemonic.Wallet.createRandomSync: Provides a synchronous alternative for creating a wallet instance with a randomly generated mnemonic.These changes collectively simplify the wallet setup process and contribute to a more intuitive and streamlined API structure.
Changes include
Checklist