-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify routine call and result handler #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvalabs-harshrastogi
added
enhancement
New feature or request
logic
Module to interact with MOI Logic Objects
providers
Issues related to providers
signer
Issues related to signer
utils
Issues related to utils
labels
Jan 29, 2024
sarvalabs-harshrastogi
requested a review
from sarvalabs-gokul
as a code owner
January 29, 2024 11:41
This was
linked to
issues
Jan 29, 2024
Deploying with Cloudflare Pages
|
sarvalabs-gokul
requested changes
Jan 29, 2024
sarvalabs-gokul
requested changes
Feb 5, 2024
sarvalabs-gokul
requested changes
Feb 5, 2024
sarvalabs-gokul
changed the title
refactor: simplify routine call and handling result
refactor: simplify routine call and result handler
Feb 5, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pull introduces the below-mentioned enhancements and fixes:
Changes:
fuelPrice
andfuelLimit
) within the ix options for logic routine calls and deployment.fuelPrice
is not explicitly provided, the system defaults to a value of 1.fuelPrice
andfuelLimit
are not provided, the implementation fetches fuel estimates using themoi.FuelEstimate
method.ix.result()
andix.wait()
to throw an error if the contract method execution encounters an error.params
field. In case of failure, developers can access the receipt througherror.params.receipt
Map
but when converted toJSON
resulted in an empty object ({}). This has been addressed.Note: This is a breaking change.
Changes include
Checklist