-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for optional nonce in logic calls #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarvalabs-harshrastogi
requested review from
sarvalabs-gokul and
sarvalabs-manish
as code owners
November 30, 2023 13:41
sarvalabs-harshrastogi
changed the title
feat: Support for optional nonce in logic calls and update docs
feat: Support for optional nonce in logic calls
Dec 1, 2023
Deploying with Cloudflare Pages
|
sarvalabs-gokul
changed the title
feat: Support for optional nonce in logic calls
feat: support for optional nonce in logic calls
Dec 1, 2023
sarvalabs-gokul
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
sarvalabs-harshrastogi
force-pushed
the
fix/logic-driver-nonce
branch
2 times, most recently
from
December 11, 2023 10:45
c654836
to
8c93f48
Compare
sarvalabs-harshrastogi
force-pushed
the
fix/logic-driver-nonce
branch
from
December 11, 2023 10:46
8c93f48
to
41f5b61
Compare
sarvalabs-gokul
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses the absence of support for an optional nonce parameter in logic calls within the moi-logic package.
Changes include
Checklist