Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support for optional nonce in logic calls #19

Merged
merged 9 commits into from
Jan 22, 2024
Merged

feat: support for optional nonce in logic calls #19

merged 9 commits into from
Jan 22, 2024

Conversation

sarvalabs-harshrastogi
Copy link
Member

@sarvalabs-harshrastogi sarvalabs-harshrastogi commented Nov 30, 2023 •
edited by sarvalabs-gokul
Loading

Description

This pull request addresses the absence of support for an optional nonce parameter in logic calls within the moi-logic package.

Changes include

  • Bugfix (non-breaking change that solves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backward-compatible and/or changes current functionality)

Checklist

  • I have assigned this PR to myself
  • I have added at least 1 reviewer
  • I have tested this code
  • I have updated the README and other relevant documents (guides...)

@sarvalabs-harshrastogi sarvalabs-harshrastogi added the bug Something isn't working label Nov 30, 2023
@sarvalabs-harshrastogi sarvalabs-harshrastogi changed the title feat: Support for optional nonce in logic calls and update docs feat: Support for optional nonce in logic calls Dec 1, 2023
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 1, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 81252ab
Status: ✅  Deploy successful!
Preview URL: https://7d613f7d.js-moi-sdk.pages.dev
Branch Preview URL: https://fix-logic-driver-nonce.js-moi-sdk.pages.dev

View logs

@sarvalabs-gokul sarvalabs-gokul changed the title feat: Support for optional nonce in logic calls feat: support for optional nonce in logic calls Dec 1, 2023
sarvalabs-gokul
sarvalabs-gokul approved these changes Dec 1, 2023
View reviewed changes
Copy link
Member

@sarvalabs-gokul sarvalabs-gokul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sarvalabs-harshrastogi sarvalabs-harshrastogi force-pushed the fix/logic-driver-nonce branch 2 times, most recently from c654836 to 8c93f48 Compare December 11, 2023 10:45
@sarvalabs-harshrastogi sarvalabs-harshrastogi changed the base branch from main to develop January 21, 2024 14:54
@sarvalabs-harshrastogi sarvalabs-harshrastogi merged commit 4c4867f into develop Jan 22, 2024
2 checks passed
@sarvalabs-harshrastogi sarvalabs-harshrastogi mentioned this pull request Jan 22, 2024
Closed
@sarvalabs-harshrastogi sarvalabs-harshrastogi deleted the fix/logic-driver-nonce branch February 5, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarvalabs-gokul sarvalabs-gokul sarvalabs-gokul approved these changes

@sarvalabs-manish sarvalabs-manish Awaiting requested review from sarvalabs-manish

Assignees

@sarvalabs-harshrastogi sarvalabs-harshrastogi

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for optional nonce in logic calls
2 participants
@sarvalabs-harshrastogi @sarvalabs-gokul