Fixed Attribute Access Issue on Card #43
Conversation
member_ids, short_id, list_id, board_id, and description are readonly properties. Changed to direct access the underlying variables: - idMembers - idShort - idList - idBoard - desc
- Refactored deserialization into class method 'from_json' for every class - Replaced some simple for loops with list comprehensions
|
@kennethzfeng I've tested your fork + fixes and I'm still getting 400 - Resource unavailable on write operations. Just curious if you still face the issue with this fix? |
YYYY-MM-DD was the chosen format due to the original intention observed in def set_due, which was different from 'self.due' assignment in Card.fetch. For practical reasons, YYYY-MM-DD was chosen. - Due date of Card is in YYYY-MM-DD format. - Extra test case was added for set_due on a card.
Fixed Attribute Access Issue on Card
| card.desc = json_obj.get('desc', '') | ||
| card.closed = json_obj['closed'] | ||
| card.url = json_obj['url'] | ||
| card.member_ids = json_obj['idMembers'] |
There was a problem hiding this comment.
card.member_ids doesn't exist, since in line 513 you use idMembers
|
I liked how you solved the problem. I fixed the problem with a different strategy in my branch onilton@55d03bf But I got your point this is bad design. My only problem with the current code right now is that we have different variables that seems to have the same behaviour/properties: like You could use Maybe the "private" variables could be like Or maybe just get rid of the |
|
BTW, there is a typo in (I know it's not your fault) I fixed it in my branch: |
Hi,
It turns out that #42 was due to access violation on readonly properties defined in class Card. Initially, I fixed #42 with a dirty fix by allowing other classes direct access to the somehow private variables on aabe9be. However, it's a bad design so I refactored the JSON deserialization so that direct access is limited within its own class (082135d).
Let me know if you want me to make additional improvements.
-KF