Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Deprecation Warning when using setuptools >= v61.0.0 #316

Merged
merged 1 commit into from
Apr 22, 2022

Conversation

ytmimi
Copy link
Contributor

@ytmimi ytmimi commented Apr 22, 2022

@matteius matteius self-requested a review April 22, 2022 20:02
@ytmimi
Copy link
Contributor Author

ytmimi commented Apr 22, 2022

@matteius thanks for reviewing the PR so quickly ❤️

@matteius matteius merged commit 544e11d into sarugaku:main Apr 22, 2022
@matteius
Copy link
Collaborator

Thanks for your contribution @ytmimi -- not sure when to do a release next, but I'd like to see if anything in the new pipenv version that gets reported in the next couple weeks traces back to requirementslib or not in case there are more changes to make.

@ytmimi ytmimi deleted the fix_setuptools_deprecation branch April 22, 2022 20:24
@ytmimi
Copy link
Contributor Author

ytmimi commented Apr 22, 2022

@matteius as I understand it requirementslib is vendored in pipenv. Would it be worth opening up a similar issue in the pipenv repo? Just want to know if there's anything else I can do to help here.

@matteius
Copy link
Collaborator

@ytmimi sure if you want to track it in pipenv open a ticket that is about -- release new version of requirementslib and vendor it in. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setuptools.config.read_configuration is deprecated
2 participants