New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/subprocess access to data objects #296

Merged

danfunk merged 4 commits into main from bugfix/subprocess-access-to-data-objects

Feb 17, 2023

Contributor

essweine commented Feb 17, 2023

This PR

updates subprocesses so that they inherit data objects from their parent process
fixes a bug where call activities were being for subprocesses (this has had no effect up until now because spiff has never distinguished the two)
creates a subprocess/call activity in _on_update_hook instead of -on_ready_before and only copies data from the parent at that point

essweine added 3 commits

February 16, 2023 12:22


          initialize subprocesses in _update_hook instead of _on_ready_before

2b14f3a


          allow subprocesses & call activities to have different data copy poli…

6c8ff5c

…cies


          make data objects referenceable within subprocesses

992c386

burnettk approved these changes

View reviewed changes

sonarcloud bot commented Feb 17, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

97.5% Coverage
0.0% Duplication


          update spiff subworkflow tasks too

6d2a203

essweine force-pushed the bugfix/subprocess-access-to-data-objects branch from 950194a to 6d2a203 Compare

February 17, 2023 17:51

danfunk merged commit b439f69 into main

danfunk deleted the bugfix/subprocess-access-to-data-objects branch

February 17, 2023 17:59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet