Feature/multiple event definition #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbirddog
reviewed
Nov 23, 2022
jbirddog
approved these changes
Nov 23, 2022
|
Kudos, SonarCloud Quality Gate passed! |
danfunk
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
MultipleEventDefinitionwhich can be used by flow-based event based gateways. Now that this event definition exists, we getMultipleandMultipleParallelevents for other types "for free". We can't create these in BPMN js, but the XML can be hand-edited and the multiple events will be parsed correctly. When we add support for these in the frontend, we should improve the testing around them; since the request was for event-based gateway support, I am leaving that until later.