Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser Information about messages, correlation keys, and the presence of lanes #262

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

danfunk
Copy link
Collaborator

@danfunk danfunk commented Nov 12, 2022

We are jumping through a lot of complex xml parsing in SpiffWorkflow-Backend because we need to know some basic information about a BPMN process at the moment it is saved. Rather than do that work in the backend, it seems better to have SpiffWorkflow Parsers provide a bit of critical information before the actual parsing occurs (but after the files are added). Makes the following information available:

  • What messages are defined at the top level of a BPMN Diagram
  • What correlation keys are defined at teh top level of a BPMN Diagram
  • If a message start event exists on a process, and what message it listens for
  • Whether a process contains lanes

…Backend because we need to know some basic information about a BPMN process at the moment it is saved. Rather than do that work in the backend, it seems better to have SpiffWorkflow handle parsing the xml and providing a bit of metadata, including:

  * What messages are defined at the top level of a BPMN Diagram
  * What correlation keys are defined at teh top level of a BPMN Diagram
  * If a message start event exists on a process, and what message it listens for
  * Whether a process contains lanes
@sonarcloud
Copy link

sonarcloud bot commented Nov 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.8% 87.8% Coverage
0.0% 0.0% Duplication

@danfunk danfunk merged commit 14d3d8c into main Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants