Bug/serializer call activity issue #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------------------- * For event_definitions.py, event_types.py we were storing internal data as a tuple (see line 203) - which is not json serializable. I just turned into a dict. * For multi-instance the runtimesvar is an integer, but that can't be a key in a json file, all keys in json must be strings, so I make sure it is always a string. * I removed the self.last_task setter in _task_completed_notify in the specs/workflow.py, because we need to set this manually (as is the case in a loopback). We now set this in specs/base TaskSpec > _on_complete(), just BEFORE we call the _on_complete_hook which can set the last_task to something else when needed. * task, set_children_future - the subworkflow is set to none at the same time the children are wiped out. Optimizations: -------------- The DMNParser was using this thing called a "parsedRef" that seemed completely pointless and replicated all the content in a DMN file. So I removed it. The DMN was repeating the serialization of every input and output for every record, adding a lot of pointless content into the serizialized output. This just references it by id.
…e definitely need to check for a string here, and seems to cause no problems if it is one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialization Fixes
Optimizations:
The DMNParser was using this thing called a "parsedRef" that seemed completely pointless and replicated all the content in a DMN file. dropping it.
The DMN was repeating the serialization of every input and output for every record, adding a lot of pointless content into the serizialized output. Now we reference it by id.